Skip to content

[IMP] Array-2 #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amitmittal117 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] Array-2 #1821

amitmittal117 wants to merge 1 commit into from

Conversation

@amitmittal117
Copy link

@amitmittal117 amitmittal117 commented Nov 26, 2025

No description provided.

@super30admin
Copy link
Owner

super30admin commented Nov 26, 2025

  • Strengths:
    • The student demonstrates a strong understanding of time and space complexity optimization.
    • The use of in-place modifications to achieve O(1) space complexity is excellent.
    • The code is well-commented and easy to follow.
  • Areas for Improvement:
    • Remove the incomplete method (findDisappearedNumbers with id = nums[0]) as it serves no purpose and could confuse readers.
    • Consider adding more detailed comments explaining the logic behind the state transitions in gameOfLife for clarity.
    • Ensure all methods are complete and functional before submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amitmittal117 @super30admin